ENH: Timestamp.__sub__(datetimelike) support non-nano #47346
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Jun 14, 2022
| # case with non-lossy rounding | ||
| ts = ts_tz | ||
|
|
||
| # choose a unit for `other` that doesn't match ts_tz's |
There was a problem hiding this comment.
Mind expanding on this comment that reso parameterization does test the > and < test?
mroeschke
reviewed
Jun 14, 2022
| assert result.value == 0 | ||
| assert result._reso == min(ts._reso, other._reso) | ||
|
|
||
| # TODO: clarify in message that add/sub is allowed only when lossless? |
mroeschke
reviewed
Jun 14, 2022
mroeschke
reviewed
Jun 14, 2022
|
updated. getting the |
This was referenced Jun 14, 2022
mroeschke
approved these changes
Jun 15, 2022
mroeschke
added
Numeric Operations
mroeschke
approved these changes
Jun 15, 2022
yehoshuadimarsky
pushed a commit
to yehoshuadimarsky/pandas
that referenced
this pull request
Jul 13, 2022
* ENH: Timestamp +- timedeltalike scalar support non-nano * ENH: Timestamp.__sub__(datetime) with non-nano * better exception message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With mixed resos, cast to the lower reso, and only if doing so is lossless.